Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make env assumptions more explicit. #3143

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Make env assumptions more explicit. #3143

merged 1 commit into from
Sep 12, 2019

Conversation

kormat
Copy link
Contributor

@kormat kormat commented Sep 12, 2019 •
edited
Loading

This change is Reviewable

oncilla
oncilla approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kormat kormat merged commit 8fa5243 into scionproto:master Sep 12, 2019
@kormat kormat deleted the kmatz branch September 12, 2019 15:43
matzf pushed a commit to netsec-ethz/scion that referenced this pull request Oct 21, 2019
@kormat @matzf
Make env assumptions more explicit. (scionproto#3143)
91f65e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oncilla oncilla oncilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kormat @oncilla