prom: Remove custom registry

[oncilla]

This change renames namespaces and removes the elem_id label from all metrics.
The element ID configured in the config is exposed through scion_elem_id.

namespace renames:

• beacon_srv -> bs
• border -> br
• cert_srv -> cs
• dispatcher -> disp
• path_srv -> ps
• sciond -> sd

fixes #3160

---

This change is 

[lukedirtwalker]

Reviewed 34 of 34 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @oncilla)

a discussion (no related file):
I think this is a partly breaking change. I would add the breaking change label. Also not in the desription that metrics will be renamed, optimally with a list of old namespace -> new_namespace.

---

---

go/cert_srv/internal/metrics/metrics.go, line 18 at r1 (raw file):

n

Also make it public?

---

go/godispatcher/internal/metrics/metrics.go, line 26 at r1 (raw file):

dispatcher

maybe disp?

---

go/lib/prom/prom.go, line 77 at r1 (raw file):

// Note this should be called before any other interaction with prometheus.
// See also: https://github.com/prometheus/client_golang/issues/515
func UseDefaultRegWithElem(elemId string) {

Why is that still here?

---

go/sciond/internal/metrics/metrics.go, line 18 at r1 (raw file):

sciond

sd ?

[oncilla]

Reviewable status: 20 of 36 files reviewed, 5 unresolved discussions (waiting on @lukedirtwalker and @oncilla)

---

go/godispatcher/internal/metrics/metrics.go, line 26 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

dispatcher

maybe disp?

Done.

---

go/lib/prom/prom.go, line 77 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Why is that still here?

Forgot to remove.
Done.

---

go/sciond/internal/metrics/metrics.go, line 18 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

sciond

sd ?

Done.

[oncilla]

Reviewable status: 20 of 36 files reviewed, 5 unresolved discussions (waiting on @lukedirtwalker and @oncilla)

a discussion (no related file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

I think this is a partly breaking change. I would add the breaking change label. Also not in the desription that metrics will be renamed, optimally with a list of old namespace -> new_namespace.

done

---

[oncilla]

Reviewable status: 20 of 36 files reviewed, 5 unresolved discussions (waiting on @lukedirtwalker)

---

go/cert_srv/internal/metrics/metrics.go, line 18 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

n

Also make it public?

Done.

[lukedirtwalker]

Reviewed 16 of 16 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[lukedirtwalker]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved