Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snet: Add Fingerprint and MTU to Path interface #3224

Merged
merged 1 commit into from
Oct 4, 2019
Merged

snet: Add Fingerprint and MTU to Path interface #3224

merged 1 commit into from
Oct 4, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Oct 4, 2019 •
edited by kormat
Loading

This change is Reviewable

@sustrik sustrik requested a review from scrye October 4, 2019 11:08
scrye
scrye approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

go/lib/snet/router.go, line 125 at r1 (raw file):

	// ASes and BRs. Other metadata, such as MTU or NextHop have no effect
	// on the fingerprint. Empty string means unknown fingerprint.
	Fingerprint() string

💯 docstring

@sustrik sustrik merged commit 3db8849 into scionproto:master Oct 4, 2019
@sustrik sustrik deleted the fingerprint branch October 4, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrye scrye scrye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sustrik @scrye