Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up host type in SCIOND-API RPC messages #3233

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Clean up host type in SCIOND-API RPC messages #3233

merged 1 commit into from
Oct 9, 2019

Conversation

scrye
Copy link
Contributor

@scrye scrye commented Oct 8, 2019 •
edited by kormat
Loading

This change is Reviewable

@scrye scrye added the refactor Change that focuses around reducing tech debt label Oct 8, 2019
@scrye scrye requested a review from lukedirtwalker October 8, 2019 14:55
@scrye scrye self-assigned this Oct 8, 2019
lukedirtwalker
lukedirtwalker approved these changes Oct 9, 2019
View reviewed changes
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit ed4d1e8 into scionproto:master Oct 9, 2019
@scrye scrye deleted the pubpr-public-address-type branch October 9, 2019 12:53
@scrye scrye mentioned this pull request Dec 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukedirtwalker lukedirtwalker lukedirtwalker approved these changes

Assignees

@scrye scrye

Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scrye @lukedirtwalker