Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus dependencies #3239

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Oct 10, 2019

This commit updates the following prometheus related dependencies:

  • github.com/prometheus/client_golang to v1.1.0
  • github.com/prometheus/procfs to v0.0.5 (required by the above)
  • github.com/prometheus/common to v0.6.0
  • github.com/prometheus/client_model to latest (no releases)

Fixes #3238


This change is Reviewable

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @karampok and @scrye)


WORKSPACE, line 334 at r1 (raw file):

go_repository(
    name = "com_github_prometheus_client_model",
    commit = "14fe0d1b01d4d5fc031dd4bec1823bd3ebbe8016",

client_golang and common go.mods refer to commit fd36f4220a901265f90734c3183c5f0c91daa0b8 so maybe we should also use this. Altough there was only a non-code change afterwards so you can also leave this.


WORKSPACE, line 346 at r1 (raw file):

go_repository(
    name = "com_github_prometheus_procfs",
    commit = "499c85531f756d1129edd26485a5f73871eeb308", #v0.0.5

client_golang refers to v0.0.3 of this in its go.mod I would also use this to make sure we use something that is compatible 3f98efb27840a48a7a2898ec80be07674d19f9c8

This commit updates the following prometheus related dependencies:
* github.com/prometheus/client_golang to v1.1.0
* github.com/prometheus/procfs to v0.0.3 (required by the above)
* github.com/prometheus/common to v0.6.0
* github.com/prometheus/client_model to latest (no releases)

Fixes scionproto#3238
@karampok karampok force-pushed the pub-update-prom-dependency branch from 6c2c859 to 4ac9e6a Compare October 10, 2019 14:09
Copy link
Contributor Author

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker and @scrye)


WORKSPACE, line 334 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

client_golang and common go.mods refer to commit fd36f4220a901265f90734c3183c5f0c91daa0b8 so maybe we should also use this. Altough there was only a non-code change afterwards so you can also leave this.

I keep this.


WORKSPACE, line 346 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

client_golang refers to v0.0.3 of this in its go.mod I would also use this to make sure we use something that is compatible 3f98efb27840a48a7a2898ec80be07674d19f9c8

Done.

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @scrye)

@karampok karampok merged commit b59de29 into scionproto:master Oct 10, 2019
@karampok karampok deleted the pub-update-prom-dependency branch October 17, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update prometheus dependency
2 participants