Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old messenger metrics implementation #3259

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Remove old messenger metrics implementation #3259

merged 1 commit into from
Oct 21, 2019

Conversation

scrye
Copy link
Contributor

@scrye scrye commented Oct 17, 2019

Fixes #3198.


This change is Reviewable

@scrye scrye added the refactor Change that focuses around reducing tech debt label Oct 17, 2019
@scrye scrye requested a review from lukedirtwalker October 17, 2019 16:20
@scrye scrye self-assigned this Oct 17, 2019
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit 5226a23 into scionproto:master Oct 21, 2019
@scrye scrye deleted the pubpr-fix-3198 branch October 21, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

messenger: drop MessengerWithMetrics
2 participants