Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

periodic: make the pkg internal only #3263

Merged
merged 1 commit into from
Oct 21, 2019
Merged

periodic: make the pkg internal only #3263

merged 1 commit into from
Oct 21, 2019

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Oct 21, 2019 •
edited by kormat
Loading

This change is Reviewable

lukedirtwalker
lukedirtwalker approved these changes Oct 21, 2019
View reviewed changes
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok merged commit 625b0a7 into scionproto:master Oct 21, 2019
@karampok karampok deleted the metrics-internal branch October 24, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukedirtwalker lukedirtwalker lukedirtwalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karampok @lukedirtwalker