topology: Reduce exposed types, remove unused code #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrye
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
a discussion (no related file):
Typo in the commit message: functinality.
This makes it easier to see what functinality is still required.
lukedirtwalker
force-pushed
the
pubReduceTopoPublic
branch
from
b93a906 to
bb84efb
Compare
lukedirtwalker
commented
Oct 29, 2019
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
Previously, scrye (Sergiu Costea) wrote…
Typo in the commit message: functinality.
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to see what functionality is still required.
This change is