Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make specifying zookeeper in topo files optional #3278

Merged
merged 3 commits into from
Oct 25, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Oct 25, 2019

For pure golang topologies we don't require zookeeper anymore,
so we should also not require zookeeper to be specified in the topo file.


This change is Reviewable

@lukedirtwalker lukedirtwalker requested a review from worxli October 25, 2019 06:28
Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @worxli)


topology/Tiny.topo, line 3 at r1 (raw file):

--- # Tiny Topology
defaults:
  zookeepers:

why do you only remove it in Tiny?

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @worxli)


topology/Tiny.topo, line 3 at r1 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

why do you only remove it in Tiny?

so that we still see how it looks like :D

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @worxli)


topology/Tiny.topo, line 3 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

so that we still see how it looks like :D

Done.

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, 3 of 3 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

For pure golang topologies we don't require zookeeper anymore,
so we should also not require zookeeper to be specified in the topo file.
Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit afe2141 into scionproto:master Oct 25, 2019
@lukedirtwalker lukedirtwalker deleted the pubdropZookeeperReq branch October 25, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants