-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make specifying zookeeper in topo files optional #3278
Make specifying zookeeper in topo files optional #3278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @worxli)
topology/Tiny.topo, line 3 at r1 (raw file):
--- # Tiny Topology defaults: zookeepers:
why do you only remove it in Tiny
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @worxli)
topology/Tiny.topo, line 3 at r1 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
why do you only remove it in
Tiny
?
so that we still see how it looks like :D
37a390f
to
884449c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @worxli)
topology/Tiny.topo, line 3 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
so that we still see how it looks like :D
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, 3 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
71aae07
to
7db0b37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved
For pure golang topologies we don't require zookeeper anymore,
so we should also not require zookeeper to be specified in the topo file.
This change is