Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topogen: Don't generate unused config files for Go #3280

Merged

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Oct 25, 2019

path_policy.yml and as.yml are not used by Go services so don't generate them when we use Go only.


This change is Reviewable

path_policy.yml and as.yml are not used by Go services so don't generate them when we use Go only.
@lukedirtwalker lukedirtwalker requested a review from worxli October 25, 2019 09:20
Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit a5c8fd9 into scionproto:master Oct 25, 2019
@lukedirtwalker lukedirtwalker deleted the pubDontGenerateUnusedFiles branch October 25, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants