br: acceptance setcap on test run #3284
Conversation
Currently, braccept needs capabilities that are set during acceptance test setup. Thus everytime time we do make, we get a new binary that needs capabilities. This change moves setting the capabilities to the acceptance test run, allowing to rebuild braccept without having to teardown->setup the acceptance test every time.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @sgmonroy and @worxli)
acceptance/brutil/common.sh, line 65 at r1 (raw file):
# XXX(kormat): This is conditional on the binary existing, because when # running on CI 'setup' is run on the host, where the binary doesn't exist.
can you add the comment from the PR description here too (second part about why it's done here rather than in test_setup?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @sgmonroy and @worxli)
acceptance/brutil/common.sh, line 65 at r1 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
can you add the comment from the PR description here too (second part about why it's done here rather than in
test_setup?
Update PR and comment.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Currently, braccept needs capabilities that are set during acceptance
test setup. Thus everytime time we do make, we get a new binary that
needs capabilities.
This change moves setting the capabilities to the acceptance test run,
allowing to rebuild braccept without having to teardown->setup the
acceptance test every time.
This change is