Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPKI: Add key commands #3308

Merged
merged 1 commit into from
Nov 5, 2019
Merged

SPKI: Add key commands #3308

merged 1 commit into from
Nov 5, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Nov 4, 2019 •
edited
Loading

Add keys {public,private} commands to the scion-pki tool.

This change is Reviewable

@oncilla oncilla added the c/tooling SCION network tools label Nov 4, 2019
@oncilla oncilla added this to the Q4S2 milestone Nov 4, 2019
@oncilla oncilla requested a review from scrye November 4, 2019 13:31
@oncilla oncilla self-assigned this Nov 4, 2019
scrye
scrye approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla
SPKI: Add key commands
2c68057 
Add `key {public,private}` commands to the scion-pki tool.
@oncilla oncilla merged commit 31e8f14 into scionproto:master Nov 5, 2019
@oncilla oncilla deleted the pub-spki-priv-key branch November 5, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrye scrye scrye approved these changes

Assignees

@oncilla oncilla

Labels
c/tooling SCION network tools
Projects
None yet
Milestone
Q4S2
Development

Successfully merging this pull request may close these issues.
2 participants
@oncilla @scrye