Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export types of Topology fields #3320

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Export types of Topology fields #3320

merged 1 commit into from
Nov 5, 2019

Conversation

scrye
Copy link
Contributor

@scrye scrye commented Nov 5, 2019 •
edited by kormat
Loading

This change is Reviewable

@scrye scrye added the refactor Change that focuses around reducing tech debt label Nov 5, 2019
@scrye scrye requested a review from lukedirtwalker November 5, 2019 12:13
@scrye scrye self-assigned this Nov 5, 2019
lukedirtwalker
lukedirtwalker approved these changes Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

lukedirtwalker
lukedirtwalker approved these changes Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @scrye)

@scrye scrye merged commit b746dfa into scionproto:master Nov 5, 2019
@scrye scrye deleted the pubpr-expose-svc-names branch November 5, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukedirtwalker lukedirtwalker lukedirtwalker approved these changes

Assignees

@scrye scrye

Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scrye @lukedirtwalker