-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python images from perapp Makefile #3343
Remove python images from perapp Makefile #3343
Conversation
They were never used, so we can safely delete them. Fixes scionproto#3339
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
a discussion (no related file):
You need to update the publish
file. Also, as I mentioned, the readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)
a discussion (no related file):
Previously, worxli (Lukas Bischofberger) wrote…
You need to update the
publish
file. Also, as I mentioned, the readme.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
docker/perapp/publish, line 9 at r2 (raw file):
echo "Tag: ${1:-}" go_images="border dispatcher_go sig beacon cert path sciond"
make that images
directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 11 of 13 files reviewed, 1 unresolved discussion (waiting on @worxli)
docker/perapp/publish, line 9 at r2 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
make that
images
directly
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
They were never used, so we can safely delete them.
Fixes #3339
This change is