Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python images from perapp Makefile #3343

Merged
merged 3 commits into from
Nov 9, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Nov 8, 2019

They were never used, so we can safely delete them.

Fixes #3339


This change is Reviewable

They were never used, so we can safely delete them.

Fixes scionproto#3339
@lukedirtwalker lukedirtwalker requested a review from worxli November 8, 2019 13:33
@lukedirtwalker lukedirtwalker changed the title Remove python images from perarpp Makefile Remove python images from perapp Makefile Nov 8, 2019
Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

a discussion (no related file):
You need to update the publish file. Also, as I mentioned, the readme.


Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)

a discussion (no related file):

Previously, worxli (Lukas Bischofberger) wrote…

You need to update the publish file. Also, as I mentioned, the readme.

Done.


Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)


docker/perapp/publish, line 9 at r2 (raw file):

echo "Tag: ${1:-}"

go_images="border dispatcher_go sig beacon cert path sciond"

make that images directly

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 13 files reviewed, 1 unresolved discussion (waiting on @worxli)


docker/perapp/publish, line 9 at r2 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

make that images directly

Done.

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit ef352a4 into scionproto:master Nov 9, 2019
@lukedirtwalker lukedirtwalker deleted the pubRemovePyPerapp branch November 9, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove python images from perapp Makefile
2 participants