-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPKI: Generate issuer and AS config for topo #3363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @oncilla)
go/tools/scion-pki/internal/v2/tmpl/topo.go, line 176 at r1 (raw file):
} func (g topoGen) genIssuerCerts(topo topoFile, cfg map[addr.ISD]conf.TRC2) error {
cfg
argument is not used. It could maybe be used to determine the TRCVersion
for the issuer cert. Else just drop it.
go/tools/scion-pki/internal/v2/tmpl/topo.go, line 208 at r1 (raw file):
} func (g topoGen) genASCerts(topo topoFile, cfg map[addr.ISD]conf.TRC2) error {
cfg
argument is not used.
go/tools/scion-pki/internal/v2/tmpl/topo_test.go, line 99 at r1 (raw file):
assert.Equal(t, algo, meta.Algorithm) assert.Equal(t, g.Validity, meta.Validity)
extra empty line. I'd move it one line below.
e4ab952
to
99ce7dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker)
go/tools/scion-pki/internal/v2/tmpl/topo.go, line 176 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
cfg
argument is not used. It could maybe be used to determine theTRCVersion
for the issuer cert. Else just drop it.
That was the plan initially, but then I dropped it because it is always 1 anyway.
go/tools/scion-pki/internal/v2/tmpl/topo.go, line 208 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
cfg
argument is not used.
Done.
go/tools/scion-pki/internal/v2/tmpl/topo_test.go, line 99 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
extra empty line. I'd move it one line below.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
This PR adds the capability to generate issuer and AS certificate config files for a given topology description. Additionally, adds missing tests for generated keys.toml.
99ce7dd
to
3c0de24
Compare
This PR adds the capability to generate issuer and AS certificate
config files for a given topology description.
Additionally, adds missing tests for generated keys.toml.
This change is