Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install python3 version of supervisor, ditch pip2 #3372

Merged
merged 4 commits into from
Nov 19, 2019

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Nov 13, 2019

This change is Reviewable

@matzf matzf force-pushed the supervisor-pip3 branch 3 times, most recently from bcf104a to d572faa Compare November 14, 2019 13:36
@matzf
Copy link
Contributor Author

matzf commented Nov 14, 2019

Note: somewhat disappointingly, the debian step still installs python2.

Edit: the python2 seems to come from installing software-properties-common (and also flake8). Also, it appears that having python2 is actually required for the dpkg_src step in bazel.

@matzf matzf force-pushed the supervisor-pip3 branch 2 times, most recently from c550bc6 to 255eaee Compare November 18, 2019 16:34
Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)

a discussion (no related file):
Needs to be rebased on master, and probably a fresh image build. Ping me when you've rebased.


Copy link
Contributor Author

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 9 files reviewed, 1 unresolved discussion (waiting on @kormat)

a discussion (no related file):

Previously, kormat (Stephen Shirley) wrote…

Needs to be rebased on master, and probably a fresh image build. Ping me when you've rebased.

Done.


Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kormat kormat merged commit 0efb181 into scionproto:master Nov 19, 2019
@matzf matzf deleted the supervisor-pip3 branch December 19, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants