-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install python3 version of supervisor, ditch pip2 #3372
Conversation
bcf104a
to
d572faa
Compare
Note: somewhat disappointingly, the debian step still installs python2. Edit: the python2 seems to come from installing software-properties-common (and also flake8). Also, it appears that having python2 is actually required for the |
c550bc6
to
255eaee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)
a discussion (no related file):
Needs to be rebased on master, and probably a fresh image build. Ping me when you've rebased.
255eaee
to
a3bce2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 9 files reviewed, 1 unresolved discussion (waiting on @kormat)
a discussion (no related file):
Previously, kormat (Stephen Shirley) wrote…
Needs to be rebased on master, and probably a fresh image build. Ping me when you've rebased.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is