sciond-API: Only have a single Connect method #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrye
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
scrye
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Reviewable status:
Instead of having one with timeout and one without just have one method with context. Also the same request id counter for all connection, to make sure that no two connection can potentially send a request with the same ID.
lukedirtwalker
force-pushed
the
pubsciondConnect
branch
from
67ef558 to
10c09b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having one with timeout and one without just have one method with context.
Also remove the request ID counter, it's no longer needed since we do single-shot connections anyway.
This change is