Upgrade water dependency #3406
Merged
Upgrade water dependency #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently we saw SIG acceptance tests fail more often that usual. Since the Go1.13 change (scionproto#3362) we saw in some SIGs problems with the TUN device. Investigating further we came across golang/go#30624. From there we saw that water library is very old and still uses os.OpenFile, which was replaced in other similar libs to mitigate afformentioned Go issue.
kormat
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
lukedirtwalker
added a commit
to lukedirtwalker/scion
that referenced
this pull request
Nov 27, 2019
This was already done by scionproto#3406 but then got reverted by the go.mod change (scionproto#3419)
lukedirtwalker
added a commit
that referenced
this pull request
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we saw SIG acceptance tests fail more often that usual.
Since the Go1.13 change (#3362) we saw in some SIGs problems with the TUN device.
Investigating further we came across golang/go#30624.
From there we saw that water library is very old and still uses os.OpenFile,
which was replaced in other similar libs to mitigate afformentioned Go issue.
This change is