Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIG: Move config to internal #3408

Merged
merged 1 commit into from
Nov 21, 2019
Merged

SIG: Move config to internal #3408

merged 1 commit into from
Nov 21, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Nov 20, 2019 •
edited by kormat
Loading

This change is Reviewable

@sustrik sustrik requested a review from karampok November 20, 2019 08:51
karampok
karampok approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 1faca3e into scionproto:master Nov 21, 2019
sustrik added a commit that referenced this pull request Nov 26, 2019
@sustrik
Revert "SIG: Move config to internal (#3408)" (#3429)
51f52bd 
This reverts commit 1faca3e.
@sustrik sustrik deleted the move-config branch November 27, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karampok karampok karampok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sustrik @karampok