messenger: use addr.AppAddr less in tests

[karampok]

As part of the remote add.AppAddr effort.

---

This change is 

[lukedirtwalker]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @karampok)

a discussion (no related file):
title: messenger: Use addr.AppAddr less and remove Convey tests

---

---

go/lib/addr/util.go, line 36 at r1 (raw file):

	}
}
func NewUDPAppAddr(u *net.UDPAddr) *AppAddr {

I think AppAddrFromUDP does everything you need ;)

---

go/lib/infra/messenger/addr_test.go, line 42 at r1 (raw file):

		input net.Addr
		want  *snet.Addr
		af    assert.ErrorAssertionFunc

asssertErr ? I think af refers to the type I don't care about the type. reading below tc.af does not tell me anything. tc.assertErr is a bit more clear.

---

go/lib/infra/messenger/addr_test.go, line 227 at r1 (raw file):

func TestResolveIfSVC(t *testing.T) {
	testCases := []struct {
		dscr                  string

I personally don't like those short forms. why not just description I can immediately see what is meant. If I see dscr I don't immediately know what it means. And all that only to save a few characters?

---

go/lib/infra/messenger/addr_test.go, line 234 at r1 (raw file):

		want                  *addr.AppAddr
		wantQUICRedirect      bool
		af                    assert.ErrorAssertionFunc

assertErr

---

go/lib/infra/messenger/addr_test.go, line 343 at r1 (raw file):

		Reply *svc.Reply
		want  *net.UDPAddr
		af    assert.ErrorAssertionFunc

dittoassertErr

[karampok]

Reviewable status: 0 of 3 files reviewed, 6 unresolved discussions (waiting on @lukedirtwalker)

a discussion (no related file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

title: messenger: Use addr.AppAddr less and remove Convey tests

Done.

---

---

go/lib/addr/util.go, line 36 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

I think AppAddrFromUDP does everything you need ;)

I will prefer to keep that because the later refactor will be more straightforward
(when NewUDP -> X, when NewSVC -?)

I brought the functions inside the test to isolate them.

---

go/lib/infra/messenger/addr_test.go, line 42 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

asssertErr ? I think af refers to the type I don't care about the type. reading below tc.af does not tell me anything. tc.assertErr is a bit more clear.

Done.

---

go/lib/infra/messenger/addr_test.go, line 227 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

I personally don't like those short forms. why not just description I can immediately see what is meant. If I see dscr I don't immediately know what it means. And all that only to save a few characters?

Transformed to map.

---

go/lib/infra/messenger/addr_test.go, line 234 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

assertErr

Done.

---

go/lib/infra/messenger/addr_test.go, line 343 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

dittoassertErr

Done.

[lukedirtwalker]

Reviewed 4 of 4 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved