invraenv: use net.UDPAddr for public/bind addr #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
karampok
force-pushed
the
pub-remove-snetaddr-from-ncconfig
branch
3 times, most recently
from
9ccd6a3 to
f74b5df
Compare
lukedirtwalker
approved these changes
Nov 25, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2.
Reviewable status:
* remove bind field as it is deprecated * replace add.AppAddr to net.UDPAddr in topo interface
karampok
force-pushed
the
pub-remove-snetaddr-from-ncconfig
branch
from
f74b5df to
eae9aa7
Compare
lukedirtwalker
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Reviewed 9 of 9 files at r3.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is