Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove addr.AppAddr usage #3443

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Dec 2, 2019

Reduce addr.AppAddr usage

  • Part of the effort to deprecate AppAddr.
  • Use net.UDPAddr
  • Remove snet.Localmachine as we deprecate bind.

Contributes to #3344


This change is Reviewable

* Part of the effort to deprecate AppAddr.
* Use net.UDPAddr
* Remove snet.Localmachine as we deprecate bind.
@karampok karampok force-pushed the pub-remove-localmachine branch from c5c3d73 to 3bc2208 Compare December 4, 2019 11:36
@karampok karampok changed the title Remove add.AppAddr usage Remove addr.AppAddr usage Dec 4, 2019
@karampok karampok marked this pull request as ready for review December 4, 2019 11:39
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 22 of 22 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok merged commit bb7990f into scionproto:master Dec 4, 2019
@karampok karampok deleted the pub-remove-localmachine branch January 29, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants