Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPKI: Display certs in a human readable format #3454

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Dec 5, 2019

Add support for displaying issuer certificates and certificate chains
in a human readable format.


This change is Reviewable

@oncilla oncilla added the c/tooling SCION network tools label Dec 5, 2019
@oncilla oncilla added this to the Q4S4.D milestone Dec 5, 2019
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)


go/tools/scion-pki/internal/v2/certs/util.go, line 60 at r1 (raw file):

		chain, _ := filepath.Match(toMatchString(pkicmn.CertNameFmt), name)
		switch {
		// Check iss first, because chain will match too.

How can this happen, shouldn't that be prevented by the file ending?


go/tools/scion-pki/internal/v2/certs/util.go, line 74 at r1 (raw file):

"%v"

this doesn't appear in the format strings?

Add support for displaying issuer certificates and certificate chains
in a human readable format.
@oncilla oncilla force-pushed the pub-spki-certs-human branch from e7f9cd2 to edc3798 Compare December 6, 2019 07:54
Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)


go/tools/scion-pki/internal/v2/certs/util.go, line 60 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

How can this happen, shouldn't that be prevented by the file ending?

oh, the name used to be different.
fixed.


go/tools/scion-pki/internal/v2/certs/util.go, line 74 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…
"%v"

this doesn't appear in the format strings?

Done.

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit 2fe4f12 into scionproto:master Dec 6, 2019
@oncilla oncilla deleted the pub-spki-certs-human branch December 6, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/tooling SCION network tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants