trust: start using snet.UDPAddr

[karampok]

which replaces the snet.Addr

Contributes: #3344

---

This change is 

[oncilla]

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @karampok)

---

go/lib/infra/modules/trust/handlers.go, line 50 at r1 (raw file):

	logger := log.FromCtx(h.request.Context())
	l := metrics.HandlerLabels{
		Client:  addrLocation(h.request.Peer, h.store.ia),

should we have an "unknown" value for this?

---

go/lib/infra/modules/trust/handlers.go, line 59 at r1 (raw file):

	peer, err := redirectToUDP(h.request.Peer)
	if err != nil {
		logger.Error("[TrustStore:trcReqHandler] wrong address type, err", err)

s/, err/", err/

---

go/lib/infra/modules/trust/handlers.go, line 61 at r1 (raw file):

		logger.Error("[TrustStore:trcReqHandler] wrong address type, err", err)
		metrics.Handler.Request(l).Inc()
		return infra.MetricsErrInternal

Not sure if this is an ErrInternal or ErrInvalid.

ErrInternal because it gets this far. ErrInvalid because its an invalid request packet

---

go/lib/infra/modules/trust/handlers.go, line 106 at r1 (raw file):

		trcObj, err = h.store.getTRC(subCtx, trcReq.ISD,
			scrypto.Version(trcReq.Version), opts, peer)

if you do getTRC(subCtx, trcReq.ISD, trcReq.Version, opts, peer), this should fit on one line

---

go/lib/infra/modules/trust/handlers.go, line 157 at r1 (raw file):

	peer, err := redirectToUDP(h.request.Peer)
	if err != nil {
		logger.Error("[TrustStore:trcReqHandler] wrong address type, err", err)

ditto

---

go/lib/infra/modules/trust/handlers.go, line 250 at r1 (raw file):

	peer, err := redirectToUDP(h.request.Peer)
	if err != nil {
		logger.Error("[TrustStore:trcReqHandler] wrong address type, err", err)

ditto

---

go/lib/infra/modules/trust/handlers.go, line 329 at r1 (raw file):

	peer, err := redirectToUDP(h.request.Peer)
	if err != nil {
		logger.Error("[TrustStore:trcReqHandler] wrong address type, err", err)

ditto

---

go/lib/infra/modules/trust/handlers.go, line 394 at r1 (raw file):

	switch p := address.(type) {
	case *snet.Addr:
		return addrLocation(p.ToXAddr(), localIA)

can we ever get into that branch?

[karampok]

Reviewable status: 6 of 7 files reviewed, 8 unresolved discussions (waiting on @karampok and @oncilla)

---

go/lib/infra/modules/trust/handlers.go, line 50 at r1 (raw file):

Previously, Oncilla wrote…

should we have an "unknown" value for this?

to my opinion no, but no strong preference

---

go/lib/infra/modules/trust/handlers.go, line 59 at r1 (raw file):

Previously, Oncilla wrote…

s/, err/", err/

Done.

---

go/lib/infra/modules/trust/handlers.go, line 61 at r1 (raw file):

Previously, Oncilla wrote…

Not sure if this is an ErrInternal or ErrInvalid.

ErrInternal because it gets this far. ErrInvalid because its an invalid request packet

some lines bellow we do the same stuff for message type, so I would say the same as there.
(but no strong preference, pick your favorite)

---

go/lib/infra/modules/trust/handlers.go, line 157 at r1 (raw file):

Previously, Oncilla wrote…

ditto

Done.

---

go/lib/infra/modules/trust/handlers.go, line 250 at r1 (raw file):

Previously, Oncilla wrote…

ditto

Done.

---

go/lib/infra/modules/trust/handlers.go, line 329 at r1 (raw file):

Previously, Oncilla wrote…

ditto

Done.

---

go/lib/infra/modules/trust/handlers.go, line 394 at r1 (raw file):

Previously, Oncilla wrote…

can we ever get into that branch?

yes, there is somewhere a store.getTRClabels where you enter the server not the client, and that is snet.Addr.

[karampok]

Reviewable status: 6 of 7 files reviewed, 8 unresolved discussions (waiting on @oncilla)

---

go/lib/infra/modules/trust/handlers.go, line 106 at r1 (raw file):

Previously, Oncilla wrote…

if you do getTRC(subCtx, trcReq.ISD, trcReq.Version, opts, peer), this should fit on one line

Done.

[oncilla]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

---

go/lib/infra/modules/trust/handlers.go, line 50 at r1 (raw file):

Previously, karampok (Konstantinos) wrote…

to my opinion no, but no strong preference

🤷‍♀️

---

go/lib/infra/modules/trust/handlers.go, line 394 at r1 (raw file):

Previously, karampok (Konstantinos) wrote…

yes, there is somewhere a store.getTRClabels where you enter the server not the client, and that is snet.Addr.

alright 👍

[oncilla]

Reviewable status: complete! all files reviewed, all discussions resolved