Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrustStore: Resolver handles certificate chains #3495

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Dec 9, 2019

This PR adds the capability to resolve certificate chains to the
resolver.

fixes #3469


This change is Reviewable

@lukedirtwalker lukedirtwalker self-requested a review December 10, 2019 16:22
This PR adds the capability to resolve certificate chains to the
resolver.

fixes scionproto#3469
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)


go/lib/infra/modules/trust/v2/resolver_test.go, line 258 at r1 (raw file):

			r := trust.NewResolver(m.DB, m.Inserter, m.RPC)
			dec, err := r.Chain(context.Background(), test.ChainReq, nil)
			if test.ExpectedErr != nil {

everything below can be simplified to:

			xtest.AssertErrorsIs(t, err, test.ExpectedErr)
			if test.ExpectedErr == nil {
				assert.Equal(t, expected, dec)
			}

Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)


go/lib/infra/modules/trust/v2/resolver_test.go, line 258 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

everything below can be simplified to:

			xtest.AssertErrorsIs(t, err, test.ExpectedErr)
			if test.ExpectedErr == nil {
				assert.Equal(t, expected, dec)
			}

Done.

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


go/lib/infra/modules/trust/v2/resolver_test.go, line 258 at r3 (raw file):

			dec, err := r.Chain(context.Background(), test.ChainReq, nil)
			xtest.AssertErrorsIs(t, err, test.ExpectedErr)
			assert.Equal(t, expected, dec)

💯 for also fixing this :)

@oncilla oncilla merged commit 1b0cf9f into scionproto:master Dec 11, 2019
@oncilla oncilla deleted the pub-trust-resolver branch December 11, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrustStore: Merge resolver
2 participants