Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topology: replace SCIONAddress to net.UDPAddr os #3507

Merged
merged 1 commit into from
Dec 11, 2019
Merged

topology: replace SCIONAddress to net.UDPAddr os #3507

merged 1 commit into from
Dec 11, 2019

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Dec 11, 2019 •
edited by kormat
Loading

Inside topology, the TopoAddr struct changed

	TopoAddr struct {
		SCIONAddress    *addr.AppAddr	-->  *net.UDPAddr
		UnderlayAddress net.Addr		
	}

This change is Reviewable

@karampok karampok requested a review from oncilla December 11, 2019 09:28
oncilla
oncilla approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 17 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

oncilla
oncilla approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok closed this Dec 11, 2019
@karampok karampok deleted the pub-removefromtopology branch December 11, 2019 09:38
@karampok karampok restored the pub-removefromtopology branch December 11, 2019 09:40
@karampok karampok reopened this Dec 11, 2019
@karampok karampok merged commit a05c93f into scionproto:master Dec 11, 2019
@karampok karampok deleted the pub-removefromtopology branch February 17, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oncilla oncilla oncilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karampok @oncilla