Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrustStore: Combine components to Store #3538

Merged
merged 4 commits into from
Dec 18, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Dec 17, 2019

This PR combines the individual components to the trust store and enables it in the topology.
Additionally, legacy reissuance handler and tasks are removed,


This change is Reviewable

@oncilla oncilla added CS c/CPPKI SCION Control-plane PKI labels Dec 17, 2019
@oncilla oncilla added this to the Q4S5.D milestone Dec 17, 2019
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 32 of 33 files at r1.
Reviewable status: 31 of 36 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker and @oncilla)


go/lib/infra/modules/trust/v2/store.go, line 41 at r1 (raw file):

// trust store is allowed to issue new TRC requests over the network.  This
// method should only be used when servicing requests coming from remote nodes.
func (s Store) NewTRCReqHandler() infra.Handler {

Could we use those methods in handlers_test.go


go/lib/infra/modules/trust/v2/store_test.go, line 104 at r1 (raw file):

			assert.NoError(t, err)
			assert.Equal(t, loadTRC(t, trc1v1).Raw, raw)
		})

Also check the chain?


go/lib/infra/modules/trust/v2/store_test.go, line 127 at r1 (raw file):

trc

chain

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 33 files at r1, 3 of 4 files at r2.
Reviewable status: 35 of 36 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker and @oncilla)

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @oncilla)

Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker)


go/lib/infra/modules/trust/v2/store.go, line 41 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Could we use those methods in handlers_test.go

Done.


go/lib/infra/modules/trust/v2/store_test.go, line 104 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Also check the chain?

Done.


go/lib/infra/modules/trust/v2/store_test.go, line 127 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…
trc

chain

Done.

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla force-pushed the pub-trust-store-definition branch from 7bfacd5 to 0d3a67e Compare December 18, 2019 09:37
@oncilla oncilla force-pushed the pub-trust-store-definition branch from 0d3a67e to 70e85d2 Compare December 18, 2019 11:20
@oncilla oncilla merged commit 1cafd78 into scionproto:master Dec 18, 2019
@oncilla oncilla deleted the pub-trust-store-definition branch December 18, 2019 13:19
@oncilla oncilla self-assigned this Dec 18, 2019
@oncilla oncilla added the i/breaking change PR that breaks forwards or backwards compatibility label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/CPPKI SCION Control-plane PKI i/breaking change PR that breaks forwards or backwards compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants