-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrustStore: Combine components to Store #3538
TrustStore: Combine components to Store #3538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 32 of 33 files at r1.
Reviewable status: 31 of 36 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker and @oncilla)
go/lib/infra/modules/trust/v2/store.go, line 41 at r1 (raw file):
// trust store is allowed to issue new TRC requests over the network. This // method should only be used when servicing requests coming from remote nodes. func (s Store) NewTRCReqHandler() infra.Handler {
Could we use those methods in handlers_test.go
go/lib/infra/modules/trust/v2/store_test.go, line 104 at r1 (raw file):
assert.NoError(t, err) assert.Equal(t, loadTRC(t, trc1v1).Raw, raw) })
Also check the chain?
go/lib/infra/modules/trust/v2/store_test.go, line 127 at r1 (raw file):
trc
chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 33 files at r1, 3 of 4 files at r2.
Reviewable status: 35 of 36 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker and @oncilla)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @oncilla)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker)
go/lib/infra/modules/trust/v2/store.go, line 41 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Could we use those methods in
handlers_test.go
Done.
go/lib/infra/modules/trust/v2/store_test.go, line 104 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Also check the chain?
Done.
go/lib/infra/modules/trust/v2/store_test.go, line 127 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
trc
chain
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
7bfacd5
to
0d3a67e
Compare
0d3a67e
to
70e85d2
Compare
This PR combines the individual components to the trust store and enables it in the topology.
Additionally, legacy reissuance handler and tasks are removed,
This change is