BR: Fatal on irrecoverable errors #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an irrecoverable error happens, the posix output routine just hangs and never terminates. With this change, the border router fatals out instead of running in a broken state, because there is no easy way for an operator to re-initialize the interface with a new output routine. fixes scionproto#3050
oncilla
force-pushed
the
pub-br-fatal
branch
from
0a5ccfe to
c17543e
Compare
sgmonroy
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an irrecoverable error happens, the posix output routine just
hangs and never terminates.
With this change, the border router fatals out instead of running in a
broken state, because there is no easy way for an operator to
re-initialize the interface with a new output routine.
fixes #3050
This change is