Cert renewal: Add request struct for v2

[lukedirtwalker]

Add the structure for the version 2 certificate renewal requests.

Fixes #3478

---

This change is 

[oncilla]

Reviewed 11 of 14 files at r1.
Reviewable status: 11 of 14 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker and @oncilla)

---

go/cert_srv/internal/reissuance/request.go, line 37 at r2 (raw file):

// BaseRequest is the base information of the reissuance request.
type BaseRequest struct {

In current PKI they call this CertificationRequestInfo https://tools.ietf.org/html/rfc2986
what about calling this field just Info?

---

go/cert_srv/internal/reissuance/request.go, line 44 at r2 (raw file):

// Request is the reissuance request.
type Request struct {

IMO, this should be structured according to the general serialization syntax https://tools.ietf.org/html/rfc7515#section-7.2.1

I.e.

type Signed struct {
  Request EncodedRequest
  Protected EncodedProtected
  Signature []byte
}

type EncodedRequest string
type EncodedProtected string

type Request struct {
  Encoded EncodedInfo `json:"payload"`
  POPs []POP `json:"signatures"`
}

type Info struct {
  cert.Base
  Issuer addr.IA
  RequestTime util.UnixTime
}


type POP struct {
  Protected EncodedPOP `json:"protected"`
  Signature scrypto.JWSignature // I will add in my PR
}

---

go/lib/ctrl/cert_mgmt/chain_iss_req.go, line 26 at r1 (raw file):

type ChainIssReq struct {
	RawCert common.RawBytes `capnp:"cert"`

make this a []byte

[lukedirtwalker]

Reviewable status: 7 of 14 files reviewed, 3 unresolved discussions (waiting on @oncilla)

---

go/cert_srv/internal/reissuance/request.go, line 37 at r2 (raw file):

Previously, Oncilla wrote…

In current PKI they call this CertificationRequestInfo https://tools.ietf.org/html/rfc2986
what about calling this field just Info?

Done. Called it RequestInfo

---

go/cert_srv/internal/reissuance/request.go, line 44 at r2 (raw file):

Previously, Oncilla wrote…

IMO, this should be structured according to the general serialization syntax https://tools.ietf.org/html/rfc7515#section-7.2.1

I.e.

type Signed struct {
  Request EncodedRequest
  Protected EncodedProtected
  Signature []byte
}

type EncodedRequest string
type EncodedProtected string

type Request struct {
  Encoded EncodedInfo `json:"payload"`
  POPs []POP `json:"signatures"`
}

type Info struct {
  cert.Base
  Issuer addr.IA
  RequestTime util.UnixTime
}


type POP struct {
  Protected EncodedPOP `json:"protected"`
  Signature scrypto.JWSignature // I will add in my PR
}

Done.

---

go/lib/ctrl/cert_mgmt/chain_iss_req.go, line 26 at r1 (raw file):

Previously, Oncilla wrote…

make this a []byte

What should the string method do then? Optimally it would parse the new request and print it, but that's not possible because it is in an internal package.

[oncilla]

Reviewed 1 of 14 files at r1, 6 of 6 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

---

go/lib/ctrl/cert_mgmt/chain_iss_req.go, line 26 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

What should the string method do then? Optimally it would parse the new request and print it, but that's not possible because it is in an internal package.

just do fmt.Sprintf("%x", c.RawCert) probably.
Using common.RawBytes just for the string method is not great.

(On that note, RawCert is not a good name anymore, since it is more than that now.)

[oncilla]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

---

go/lib/ctrl/cert_mgmt/chain_iss_req.go, line 26 at r1 (raw file):

Previously, Oncilla wrote…

just do fmt.Sprintf("%x", c.RawCert) probably.
Using common.RawBytes just for the string method is not great.

(On that note, RawCert is not a good name anymore, since it is more than that now.)

Thinking about it further, I think the RequestInfo should live in the go/lib/scrypto/cert/v2/renewal package.

As we discussed, we might want to build a tool to send requests independent of the CS.

[lukedirtwalker]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)

---

go/lib/ctrl/cert_mgmt/chain_iss_req.go, line 26 at r1 (raw file):

Previously, Oncilla wrote…

Thinking about it further, I think the RequestInfo should live in the go/lib/scrypto/cert/v2/renewal package.

As we discussed, we might want to build a tool to send requests independent of the CS.

Done.

[oncilla]

Reviewed 9 of 9 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved

[oncilla]

Reviewable status: complete! all files reviewed, all discussions resolved

[oncilla]

Reviewed 1 of 1 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved