CI: add revocation tests to pipeline 2

[lukedirtwalker]

Also:

• introduce test artifacts variable as a dir that always exists ready for tests to be used.
• use test artifacts for diff tests in check generated tasks, this dir always exists also on the local CI.
• generate acceptance steps for bazelified acceptance tests.

---

This change is 

[worxli]

Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker and @worxli)

---

.buildkite/pipeline2.sh, line 26 at r1 (raw file):

# gen_acceptance2 generates steps for bazel tests in acceptance folder.
gen_acceptance2() {

maybe gen_bazel_acceptance ?

---

.buildkite/hooks/pre-command, line 10 at r1 (raw file):

if [ "$BUILDKITE_PIPELINE_SLUG" == "scionproto2" ]; then
    export ACCEPTANCE_ARTIFACTS="$PWD/accept_artifacts"

can we rename the dir and the env var to something different because it's now used not only for acceptance tests? in gen_acceptance2() { you can then set ACCEPTANCE_ARTIFACTS to e.g. ARTIFACTS_DIR in the env section.

[lukedirtwalker]

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @worxli)

---

.buildkite/pipeline2.sh, line 26 at r1 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

maybe gen_bazel_acceptance ?

Done.

---

.buildkite/hooks/pre-command, line 10 at r1 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

can we rename the dir and the env var to something different because it's now used not only for acceptance tests? in gen_acceptance2() { you can then set ACCEPTANCE_ARTIFACTS to e.g. ARTIFACTS_DIR in the env section.

Done.

[worxli]

Reviewed 5 of 5 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved