-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SH: Only build necessary binaries #3566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 16 of 16 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @oncilla)
scion.sh, line 28 at r1 (raw file):
|| return 1
is that needed? we already have set -e
scion.sh, line 29 at r1 (raw file):
# Build the necessary binaries. bazel build //:scion-topo || return 1 tar --overwrite -xf bazel-bin/scion-topo.tar -C bin
why the tab here?
scion.sh, line 435 at r1 (raw file):
$PROGRAM version Show version information. $PROGRAM traces [folder]
unrelated but, can you please fix the indentation here as well?
scion.sh, line 461 at r1 (raw file):
case "$COMMAND" in coverage|help|lint|run|mstart|mstatus|mstop|stop|status|test|topology|version|build|clean|sciond|traces|stop_traces|topo_clean)
I think the change would be less "breaking" if we just left the build command. Just reduce it to make -s
if we remove it we should also remove it in go/lib/integration/README.md
The topology generator only uses two binaries when running. With this change, scion.sh only builds the necessary binaries instead of all binaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @lukedirtwalker)
scion.sh, line 28 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
|| return 1
is that needed? we already have
set -e
I guess, there was an exit before but not really sure why 🤷♀️
scion.sh, line 29 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
why the tab here?
Done.
scion.sh, line 435 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
unrelated but, can you please fix the indentation here as well?
Done.
scion.sh, line 461 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
I think the change would be less "breaking" if we just left the build command. Just reduce it to
make -s
if we remove it we should also remove it in
go/lib/integration/README.md
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
The topology generator only uses two binaries when running.
With this change, scion.sh only builds the necessary binaries instead
of all binaries.
This change is