Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AppAddr from SIG code #3578

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Remove AppAddr from SIG code #3578

merged 2 commits into from
Jan 8, 2020

Conversation

scrye
Copy link
Contributor

@scrye scrye commented Jan 6, 2020 •
edited by kormat
Loading

This change is Reviewable

@scrye scrye requested a review from karampok January 6, 2020 15:57
@scrye scrye self-assigned this Jan 6, 2020
karampok
karampok approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit 02277b4 into scionproto:master Jan 8, 2020
@scrye scrye deleted the pubpr-remove-appaddr-sig branch January 8, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karampok karampok karampok approved these changes

Assignees

@scrye scrye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scrye @karampok