Topo file: add support for v2 trust attributes #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source file for topology generation now has support for primary attributes as listed in https://github.com/Anapaya/scion/blob/anapaya/doc/ControlPlanePKI.md#primary-ases Also add support to scion-pki for those properties.
oncilla
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
oncilla
added a commit
to oncilla/scion
that referenced
this pull request
Jan 8, 2020
This fixes template generation bugs introduced by scionproto#3586
oncilla
added a commit
that referenced
this pull request
Jan 8, 2020
This fixes template generation bugs introduced by #3586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source file for topology generation now has support for primary attributes as listed in
https://github.com/scionproto/scion/blob/master/doc/ControlPlanePKI.md#primary-ases
Also add support to scion-pki for those properties.
This change is