Add support for log compression

[scrye]

Fixes #1924.

---

This change is 

[kormat]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @karampok and @scrye)

---

go/lib/log/log.go, line 75 at r1 (raw file):

		MaxAge:     logAge,  // days
		MaxBackups: logBackups,
		Compress:   true,

That's prooobably not what you wanted to do :)

[scrye]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @karampok and @kormat)

---

go/lib/log/log.go, line 75 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

That's prooobably not what you wanted to do :)

The beauty of no acceptance tests for this 🎉. Fixed :)

[kormat]

Reviewed 1 of 1 files at r2.
Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @karampok)

[kormat]

Reviewed 5 of 6 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @karampok)

[karampok]

Reviewable status: complete! all files reviewed, all discussions resolved

---

go/lib/log/flags.go, line 31 at r2 (raw file):

	logBackups  int
	logFlush    int
	logCompress bool

having inside log package a variable starting with logX seems redundant.
(log.logX)

---

go/lib/log/log.go, line 57 at r2 (raw file):

// logFlush = 0 logging output is unbuffered and Flush() is a no-op.
// Set compress to true to enable rotated file compression.
func SetupLogFile(name string, logDir string, logLevel string, logSize int, logAge int,

more than three arguments, should be a struct. But not important.
Another golang stylish comment
func SetupLogFile( name, dir, level string, size,age int)

[karampok]

Reviewable status: complete! all files reviewed, all discussions resolved

[scrye]

---

go/lib/log/log.go, line 57 at r2 (raw file):

Previously, karampok (Konstantinos) wrote…

more than three arguments, should be a struct. But not important.
Another golang stylish comment
func SetupLogFile( name, dir, level string, size,age int)

This is something I was also thinking about; the refactor was unnecessarily painful due to this not taking a struct.

Added to #3594.

[scrye]

---

go/lib/log/flags.go, line 31 at r2 (raw file):

Previously, karampok (Konstantinos) wrote…

having inside log package a variable starting with logX seems redundant.
(log.logX)

This is a good point, added to #3594.