Delete old crypto code move v2 inplace #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
added
the
i/breaking change
oncilla
requested changes
Jan 10, 2020
There was a problem hiding this comment.
Reviewed 310 of 310 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)
go/tools/scion-pki/internal/certs/cmd.go, line 84 at r1 (raw file):
the TRC referenced by the issuer certificate must also be present. See 'scion-pki help v2 certs' for information on the selector.
drop v2
go/tools/scion-pki/internal/certs/cmd.go:See 'scion-pki help v2 certs' for information on the selector.
go/tools/scion-pki/internal/certs/cmd.go:See 'scion-pki help v2 certs' for information on the selector.
go/tools/scion-pki/internal/keys/cmd.go:file structure. See 'scion-pki help v2' for more information.
go/tools/scion-pki/internal/keys/cmd.go:See 'scion-pki help v2 keys' for information on the selector.
go/tools/scion-pki/internal/keys/cmd.go:See 'scion-pki help v2 keys' for information on the selector.
go/lib/scrypto/trc/update_test.go, line 25 at r1 (raw file):
"github.com/scionproto/scion/go/lib/addr" "github.com/scionproto/scion/go/lib/scrypto" trc "github.com/scionproto/scion/go/lib/scrypto/trc"
drop named import
go/lib/scrypto/trc/primary_json_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc"
go/lib/scrypto/trc/primary_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc"
go/lib/scrypto/trc/signed_json_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc"
go/lib/scrypto/trc/signed_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc"
go/lib/scrypto/trc/trc_json_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc"
go/lib/scrypto/trc/trc_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc"
go/lib/scrypto/trc/update_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc"
go/lib/scrypto/trc/verify_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc"
This moves the new TRC, Cert v2 code into the place of the old code. Also moves v2 in the scion-pki to the parent folder. This PR deletes cryptosyncer of the PS and custpk-load tool, because they used the old API. Those removed processes have to be rewritten against the new version of the code.
lukedirtwalker
force-pushed
the
pubSPKIV2
branch
from
d299f92 to
7d93d8f
Compare
lukedirtwalker
commented
Jan 10, 2020
There was a problem hiding this comment.
Reviewable status: 300 of 310 files reviewed, 2 unresolved discussions (waiting on @oncilla)
go/tools/scion-pki/internal/certs/cmd.go, line 84 at r1 (raw file):
Previously, Oncilla wrote…
drop v2
go/tools/scion-pki/internal/certs/cmd.go:See 'scion-pki help v2 certs' for information on the selector. go/tools/scion-pki/internal/certs/cmd.go:See 'scion-pki help v2 certs' for information on the selector. go/tools/scion-pki/internal/keys/cmd.go:file structure. See 'scion-pki help v2' for more information. go/tools/scion-pki/internal/keys/cmd.go:See 'scion-pki help v2 keys' for information on the selector. go/tools/scion-pki/internal/keys/cmd.go:See 'scion-pki help v2 keys' for information on the selector.
Done.
go/lib/scrypto/trc/update_test.go, line 25 at r1 (raw file):
Previously, Oncilla wrote…
drop named import
go/lib/scrypto/trc/primary_json_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc" go/lib/scrypto/trc/primary_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc" go/lib/scrypto/trc/signed_json_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc" go/lib/scrypto/trc/signed_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc" go/lib/scrypto/trc/trc_json_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc" go/lib/scrypto/trc/trc_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc" go/lib/scrypto/trc/update_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc" go/lib/scrypto/trc/verify_test.go: trc "github.com/scionproto/scion/go/lib/scrypto/trc"
Done.
oncilla
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Reviewed 10 of 10 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the new TRC, Cert v2 code into the place of the old code.
Also moves v2 in the scion-pki to the parent folder.
This PR deletes cryptosyncer of the PS and custpk-load tool, because they used the old API.
Those removed processes have to be rewritten against the new version of the code.
This change is