Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gomocks #3606

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Fix gomocks #3606

merged 1 commit into from
Jan 14, 2020

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Jan 14, 2020

This was broken with the monolith service commit:
#3590


This change is Reviewable

This was broken with the monolith service commit:
scionproto#3590
@lukedirtwalker lukedirtwalker requested a review from scrye January 14, 2020 11:29
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit ea5caf5 into scionproto:master Jan 14, 2020
@lukedirtwalker lukedirtwalker deleted the pubFixMocks branch January 14, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants