Add primary attributes to topology file #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
added
the
i/breaking change
karampok
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Reviewed 33 of 33 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
a discussion (no related file):
In the description I will link the relevant pki documentation
lukedirtwalker
commented
Jan 14, 2020
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karampok)
a discussion (no related file):
Previously, karampok (Konstantinos) wrote…
In the description I will link the relevant pki documentation
Done.
karampok
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
Also fix topology generator to handle those attributes.
lukedirtwalker
force-pushed
the
pubTopologyAttributes
branch
from
bb591a7 to
86f90f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the primary attributes to toplogy files. The primary attributes are described in:
https://github.com/scionproto/scion/blob/master/doc/ControlPlanePKI.md#primary-ases
This fixes the toplogy generator to handle this.
This is a breaking change, old topology file will have to be updated and replace the old
Coreboolean with the attributes array.An easy migration strategy is to just put all attributes for previous cores, and no attributes for non-cores.
This change is