-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP status pages #3608
Add HTTP status pages #3608
Conversation
The HTTP pages are exposed via the existing monitoring port. 1. Add config page to all SCION services (content of the toml config) 2. Add info page to all SCION services (just the build version at the moment) 3. Add topology page to all SCION services (content of loaded topology)
2347e0e
to
304ae28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, 1 of 3 files at r2.
Reviewable status: 9 of 11 files reviewed, 4 unresolved discussions (waiting on @lukedirtwalker and @sustrik)
go/border/brconf/BUILD.bazel, line 27 at r2 (raw file):
name = "go_default_test", srcs = ["params_test.go"], data = glob(["testdata/**"]),
Why is this needed?
go/cert_srv/main.go, line 186 at r1 (raw file):
http.HandleFunc("/info", env.InfoHandler) http.HandleFunc("/topology", itopo.TopologyHandler) cfg.Metrics.StartPrometheus()
Was it the case that prom server was not running at all in CS?
go/path_srv/main.go, line 324 at r1 (raw file):
var buf bytes.Buffer toml.NewEncoder(&buf).Encode(cfg) fmt.Fprint(w, buf.String())
Missing newline
go/sciond/main.go, line 300 at r1 (raw file):
var buf bytes.Buffer toml.NewEncoder(&buf).Encode(cfg) fmt.Fprint(w, buf.String())
Missing newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 9 of 11 files reviewed, 4 unresolved discussions (waiting on @sustrik)
go/border/brconf/BUILD.bazel, line 27 at r2 (raw file):
Previously, sustrik (Martin Sustrik) wrote…
Why is this needed?
I just ran make gazelle
and this was added
go/cert_srv/main.go, line 186 at r1 (raw file):
Previously, sustrik (Martin Sustrik) wrote…
Was it the case that prom server was not running at all in CS?
Yes just checked on master, CS doesn't export metrics. Maybe it got lost during a refactoring.
go/path_srv/main.go, line 324 at r1 (raw file):
Previously, sustrik (Martin Sustrik) wrote…
Missing newline
Done.
go/sciond/main.go, line 300 at r1 (raw file):
Previously, sustrik (Martin Sustrik) wrote…
Missing newline
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
The HTTP pages are exposed via the existing monitoring port.
This change is