Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal fix for
snet.Conn.Write
.Previously, passing
nil
intoWriteTo
would automatically pick theconnected remote address, if available. With some of the previous
refactoring (amongst other, in #3571), this is no longer the case. Right
now,
Write
is simply broken.Apply the simplest fix, just specify to use the connected address
(
base.remote
) inWrite
. Note that the behaviour is still subtlydifferent than it used to be (e.g. no error if WriteTo is invoked on a
connected socket), but this seems to be the accepted behaviour change
within the refactoring in #3571.
Additionally, add a specific error message for the
nil
address casein
WriteTo
, as "Unable to write to non-SCION address" was misleading.This change is