TrustStore: Improve error context

[oncilla]

Attach error context on wrapping:

Before:

2020-01-20 08:51:42.945524+0000 [EROR] Unable to get paths debug_id=7d9353b5 err=
>  unable to get latest TRC isd="3"
>      unable to get requested TRC
>      unable to resolve signed TRC from network
>      unable to resolve latest version
>      unable to resolve latest TRC
>      not found

After:

2020-01-20 15:20:40.198528+0000 [EROR] Unable to get paths debug_id=3b8c4bb6 err=
>  unable to get requested TRC isd="3" version="latest"
>      unable to fetch signed TRC from network addr="1-ff00:0:112,CS A (0x0002)"
>      error resolving latest TRC version number
>      rpc: error from remote: "not found"

Additionally, purge remains of trust v1

fixes #3618

---

This change is 

[lukedirtwalker]

Reviewed 18 of 18 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @oncilla)

---

go/lib/infra/common.go, line 397 at r1 (raw file):

rpc error message

what about rpc: error from remote: to be a bit less ambiguous

---

go/lib/infra/modules/trust/resolver.go, line 156 at r1 (raw file):

		rawTRC, err := r.RPC.GetTRC(ctx, req, server)
		if err != nil {
			res <- resOrErr{Err: serrors.WrapStr("error requesting TRC", err,

Do we still need the additional context here, if we could remove it above in resolveLatestVersion ?

---

go/lib/infra/modules/trust/resolver.go, line 164 at r1 (raw file):

		decTRC, err := decoded.DecodeTRC(rawTRC)
		if err != nil {
			res <- resOrErr{Err: serrors.WrapStr("failed to parse TRC", err,

Do we still need the additional context here, if we could remove it above in resolveLatestVersion ?

---

go/lib/infra/modules/trust/resolver.go, line 202 at r1 (raw file):

	msg, err := r.RPC.GetCertChain(ctx, req, server)
	if err != nil {
		return decoded.Chain{}, serrors.WrapStr("rpc failed", err)

this is probably not needed?

[oncilla]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @lukedirtwalker)

---

go/lib/infra/common.go, line 397 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

rpc error message

what about rpc: error from remote: to be a bit less ambiguous

Done.

---

go/lib/infra/modules/trust/resolver.go, line 156 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Do we still need the additional context here, if we could remove it above in resolveLatestVersion ?

yes. This is additional context tells us which link we failed to fetch.
Otherwise the information is lost when reading the results from the channel.

---

go/lib/infra/modules/trust/resolver.go, line 164 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Do we still need the additional context here, if we could remove it above in resolveLatestVersion ?

ditto

---

go/lib/infra/modules/trust/resolver.go, line 202 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

this is probably not needed?

Done.

[lukedirtwalker]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved