Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context when config loading or log init fails #3624

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Jan 21, 2020

Fixes #3413


This change is Reviewable

@lukedirtwalker lukedirtwalker requested a review from kormat January 21, 2020 08:40
Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 6f99584 into scionproto:master Jan 21, 2020
@lukedirtwalker lukedirtwalker deleted the pubCfgContext branch January 21, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BS: give more context to toml parsing errors
2 participants