TrustStore: Ensure referenced TRC is available

[oncilla]

When verifying a signature, the verifier now makes sure to have the
referenced TRC available locally.

This is one mechanism how TRC updates are disseminated.

---

This change is 

[karampok]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @karampok and @oncilla)

a discussion (no related file):

This is one mechanism how TRC updates are disseminated.
what does it mean?

---

---

go/lib/infra/modules/trust/verifier.go, line 114 at r1 (raw file):

		AllowInactive:  true,
	}
	if _, err := v.Store.GetTRC(ctx, TRCID{ISD: src.IA.I, Version: src.TRCVer}, tOpts); err != nil {

I find this not very intuitive:
you run a function that will load the correct TRC in the db (is it a blocking operation?)
then you ran another function that will do something (no idea if TRC is being used).

So I would like to see how trc, trcVer,asCert is connected to the verification process.
Something like this

...
trc, err := v.Store.GetTRC()

as, err:= getAS()

if !valid(trc, as){
 return error
}
...

alternatively you could put the getTRC call when you actually try to get and use the TRC (inside GetASKey)

[oncilla]

Reviewed 5 of 5 files at r2.
Dismissed @karampok from a discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karampok)

---

go/lib/infra/modules/trust/verifier.go, line 114 at r1 (raw file):

Previously, karampok (Konstantinos) wrote…

I find this not very intuitive:
you run a function that will load the correct TRC in the db (is it a blocking operation?)
then you ran another function that will do something (no idea if TRC is being used).

So I would like to see how trc, trcVer,asCert is connected to the verification process.
Something like this

...
trc, err := v.Store.GetTRC()

as, err:= getAS()

if !valid(trc, as){
 return error
}
...

alternatively you could put the getTRC call when you actually try to get and use the TRC (inside GetASKey)

The issuer here is that the source contains two kinds of information,

[oncilla]

Dismissed @karampok from a discussion.
Reviewable status: all files reviewed, 1 unresolved discussion