-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use snet.{UDP,SVC}Addr instead of snet.Addr everywhere #3631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 43 of 43 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)
go/tools/scmp/cmn/common.go, line 79 at r2 (raw file):
flag.UintVar(&Count, "c", 0, "Total number of packet to send (echo only). Maximum value 65535") flag.Var((*snet.UDPAddr)(&Local), "local", "(Mandatory) address to listen on") flag.Var((*snet.UDPAddr)(&Remote), "remote", "(Mandatory for clients) address to connect to")
Unnecessary cast?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)
go/tools/scmp/cmn/common.go, line 79 at r2 (raw file):
Previously, matzf (Matthias Frei) wrote…
Unnecessary cast?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is