Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use snet.{UDP,SVC}Addr instead of snet.Addr everywhere #3631

Merged
merged 4 commits into from
Jan 22, 2020
Merged

Use snet.{UDP,SVC}Addr instead of snet.Addr everywhere #3631

merged 4 commits into from
Jan 22, 2020

Conversation

scrye
Copy link
Contributor

@scrye scrye commented Jan 22, 2020

This change is Reviewable

@scrye scrye added the refactor Change that focuses around reducing tech debt label Jan 22, 2020
@scrye scrye requested a review from karampok January 22, 2020 10:00
@scrye scrye self-assigned this Jan 22, 2020
Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 43 of 43 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)


go/tools/scmp/cmn/common.go, line 79 at r2 (raw file):

	flag.UintVar(&Count, "c", 0, "Total number of packet to send (echo only). Maximum value 65535")
	flag.Var((*snet.UDPAddr)(&Local), "local", "(Mandatory) address to listen on")
	flag.Var((*snet.UDPAddr)(&Remote), "remote", "(Mandatory for clients) address to connect to")

Unnecessary cast?

Copy link
Contributor Author

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)


go/tools/scmp/cmn/common.go, line 79 at r2 (raw file):

Previously, matzf (Matthias Frei) wrote…

Unnecessary cast?

Done.

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit 8e6d4db into scionproto:master Jan 22, 2020
@scrye scrye deleted the pubpr-remove-snet-addr-uses branch January 22, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants