Remove snet.Addr

[lukedirtwalker]

Remove snet.Addr, and constructors for snet.SVCAddr and snet.UDPAddr, instead use the struct directly.

Contributes #3136

---

This change is 

[matzf]

Reviewed 18 of 47 files at r1.
Reviewable status: 18 of 47 files reviewed, 1 unresolved discussion (waiting on @karampok and @lukedirtwalker)

---

go/lib/snet/snet.go, line 116 at r1 (raw file):

	}
	snetConn := conn.(*SCIONConn)
	snetConn.remote = &UDPAddr{

It would be nice to add an actual Copy function to *UDPAddr and *SVCAddr and use it here.

[karampok]

Reviewed 29 of 47 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

[lukedirtwalker]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)

---

go/lib/snet/snet.go, line 116 at r1 (raw file):

Previously, matzf (Matthias Frei) wrote…

It would be nice to add an actual Copy function to *UDPAddr and *SVCAddr and use it here.

Done.

[matzf]

Reviewed 4 of 4 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[karampok]

Reviewable status: complete! all files reviewed, all discussions resolved