SIG: Dispatcher bypass

[sustrik]

This change is 

[karampok]

Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, 4 unresolved discussions (waiting on @karampok and @sustrik)

---

go/sig/internal/sigcmn/common.go, line 53 at r1 (raw file):

	PathMgr    pathmgr.Resolver
	Dispatcher reliable.Dispatcher

I would prefer that we do not use global variables

---

go/sig/internal/sigcmn/common.go, line 91 at r1 (raw file):

		return nil, nil, serrors.WrapStr("unable to initialize SCION dispatcher", err)
	}
	if sdCfg.FakeData != "" {

fake? what is the prod use case for that?

---

go/sig/internal/sigcmn/common.go, line 133 at r1 (raw file):

}

func newDispatcher(cfg sigconfig.SigConf) (reliable.Dispatcher, error) {

Any test for the code?

---

go/sig/internal/sigcmn/common.go, line 134 at r1 (raw file):

func newDispatcher(cfg sigconfig.SigConf) (reliable.Dispatcher, error) {
	if len(cfg.DispatcherBypass) == 0 {

This is string, can you compare it to an empty string?

[sustrik]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @karampok)

---

go/sig/internal/sigcmn/common.go, line 134 at r1 (raw file):

Previously, karampok (Konstantinos) wrote…

This is string, can you compare it to an empty string?

Done.

[karampok]

Reviewed 1 of 3 files at r1, 2 of 3 files at r2, 2 of 2 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)

---

go/sig/internal/egress2/perf2/perf2.go, line 1 at r2 (raw file):

package main

mistake?

[karampok]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)