Remove unused sd_client config from control service #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)
go/cs/config/config.go, line 95 at r1 (raw file):
CS CSConfig PS PSConfig EnableQUICTest bool
Please also delete this one, while you're at it.
lukedirtwalker
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
stygerma
pushed a commit
to stygerma/scion
that referenced
this pull request
Mar 26, 2020
The control service does not use the `sd_client` option, as it does not use SCIOND (c.f. scionproto#3652, "routing is done directly on top of the path database, instead of going through SCIOND"). Also removes the old `EnableQUICTest` flag, that isn't used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The control service does not use the
sd_clientoption, as it does not use SCIOND (c.f. #3652, "routing is done directly on top of the path database, instead of going through SCIOND").Also removes the old
EnableQUICTestflag, that isn't used.This change is