Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused/obsolete python code #3670

Merged
merged 11 commits into from
Feb 20, 2020

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Feb 18, 2020

This change is Reviewable

@lukedirtwalker lukedirtwalker self-requested a review February 20, 2020 06:16
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 28 of 28 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)


python/lib/defines.py, line 24 at r1 (raw file):

#: Default TTL of a PathSegment in realtime seconds.
DEFAULT_SEGMENT_TTL = 6 * 60 * 60

Please also delete this and the argument to the generator that uses this. It isn't used.

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: 💯

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)

Copy link
Contributor Author

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 27 of 29 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)


python/lib/defines.py, line 24 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Please also delete this and the argument to the generator that uses this. It isn't used.

Done.

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit b98c24f into scionproto:master Feb 20, 2020
@matzf matzf deleted the py-remove-unused branch February 20, 2020 12:49
stygerma pushed a commit to stygerma/scion that referenced this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants