-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused/obsolete python code #3670
Conversation
4cc054c
to
1c35fdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 28 of 28 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)
python/lib/defines.py, line 24 at r1 (raw file):
#: Default TTL of a PathSegment in realtime seconds. DEFAULT_SEGMENT_TTL = 6 * 60 * 60
Please also delete this and the argument to the generator that uses this. It isn't used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 27 of 29 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
python/lib/defines.py, line 24 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Please also delete this and the argument to the generator that uses this. It isn't used.
Done.
aa02406
to
0f9ea1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Only used to check written topology files, does not seem worth the LoCs.
0f9ea1f
to
71a3478
Compare
This change is