Guard against system clock moving backwards. #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormat
force-pushed
the
br_clock_jump
branch
from
f7b65bb to
d5daf2d
Compare
sgmonroy
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
sgmonroy
suggested changes
Feb 27, 2020
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @kormat and @sgmonroy)
go/lib/overlay/conn/conn.go, line 319 at r1 (raw file):
// Guard against the system clock moving backwards. if meta.Recvd.After(readTime) { meta.Recvd = readTime
Just note to self: this is done because meta.Recvd is effectively `rp.TimeIn.
sgmonroy
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
The timestamp returned from the kernel is in system time. This means it's possible for the kernel received time to appear after the application receives the packet, which then can cause logic errors to occur in code that depends on the ordering of these timestamps. Also guard against this in the BR's packet processing time metric calculation, as system time could move backwards during the processing of a packet.
kormat
force-pushed
the
br_clock_jump
branch
from
219ae4b to
d0ae765
Compare
stygerma
pushed a commit
to stygerma/scion
that referenced
this pull request
Mar 26, 2020
The timestamp returned from the kernel is in system time. This means it's possible for the kernel received time to appear after the application receives the packet, which then can cause logic errors to occur in code that depends on the ordering of these timestamps. Also guard against this in the BR's packet processing time metric calculation, as system time could move backwards during the processing of a packet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timestamp returned from the kernel is in system time. This means
it's possible for the kernel received time to appear after the
application receives the packet, which then can cause logic errors to
occur in code that depends on the ordering of these timestamps.
Also guard against this in the BR's packet processing time metric
calculation, as system time could move backwards during the processing
of a packet.
This change is