Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snet: API function/type renaming #3690

Merged
merged 5 commits into from
Mar 24, 2020
Merged

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Mar 19, 2020

  • Rename UDPAddrFromString to ParseUDPAddr
  • Rename SCIONPacket to Packet, SCIONPacketInfo to PacketInfo
  • Remove snet.Conn interface, rename SCIONConn to Conn

This breaks the API.

Contributes #3136
Closes #3675


This change is Reviewable

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 34 of 34 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 34 of 34 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye added the i/breaking change PR that breaks forwards or backwards compatibility label Mar 24, 2020
@scrye scrye merged commit 103b370 into scionproto:master Mar 24, 2020
@matzf matzf deleted the snet-renaming branch March 24, 2020 15:58
stygerma pushed a commit to stygerma/scion that referenced this pull request Apr 22, 2020
- Rename UDPAddrFromString to ParseUDPAddr
- Rename SCIONPacket to Packet, SCIONPacketInfo to PacketInfo
- Remove snet.Conn interface, rename SCIONConn to Conn

This breaks the API.

Contributes scionproto#3136
Closes scionproto#3675
stygerma pushed a commit to stygerma/scion that referenced this pull request Apr 22, 2020
- Rename UDPAddrFromString to ParseUDPAddr
- Rename SCIONPacket to Packet, SCIONPacketInfo to PacketInfo
- Remove snet.Conn interface, rename SCIONConn to Conn

This breaks the API.

Contributes scionproto#3136
Closes scionproto#3675
stygerma pushed a commit to stygerma/scion that referenced this pull request Apr 22, 2020
- Rename UDPAddrFromString to ParseUDPAddr
- Rename SCIONPacket to Packet, SCIONPacketInfo to PacketInfo
- Remove snet.Conn interface, rename SCIONConn to Conn

This breaks the API.

Contributes scionproto#3136
Closes scionproto#3675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i/breaking change PR that breaks forwards or backwards compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snet: Rename UDPAddrFromString to ParseUDPAddr
3 participants