colibri: ctrl response types #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
requested changes
Apr 15, 2020
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @juagargi)
go/lib/ctrl/colibri_mgmt/colibri_mgmt_test.go, line 351 at r1 (raw file):
buffer, err := root.PackRoot() require.NoError(t, err) copy, err := colibri_mgmt.NewFromRaw(buffer)
please don't shadow key words.
juagargi
commented
Apr 15, 2020
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/lib/ctrl/colibri_mgmt/colibri_mgmt_test.go, line 351 at r1 (raw file):
Previously, Oncilla wrote…
please don't shadow key words.
Done.
juagargi
force-pushed
the
colibri.response_ctrl_types
branch
from
7a5c748 to
7a3bc64
Compare
oncilla
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
oncilla
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the response types for colibri control messages.
This change is